RFR: 8355632: WhiteBox.waitForReferenceProcessing() fails assert for return type

[Kim Barrett]

On Fri, 25 Apr 2025 23:37:13 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> The newly-added `WhiteBox.waitForReferenceProcessing()` (see [8305186](https://bugs.openjdk.org/browse/JDK-8305186)) always fails with assertions enabled.
> I've updated the assertion, and also added the test I used locally to test the new method (just not with assertions enabled, apparently.)

Changes requested by kbarrett (Reviewer).

test/hotspot/jtreg/vmTestbase/gc/gctests/ReferencesGC/WaitForRefProTest.java line 1:

> 1: /*

Wrong place for this test. vmTestbase is old tests, converted from an old testing infrastructure.
See the readme here:  https://github.com/openjdk/jdk/tree/master/test/hotspot/jtreg/vmTestbase
In particular, at the bottom of that page: "New tests must *not* be added into this directory."

This new test belongs in `test/lib-test/jdk/test/whitebox/`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/24892#pullrequestreview-2795859193
PR Review Comment: https://git.openjdk.org/jdk/pull/24892#discussion_r2061239344