RFR: 8341275: Explicit counter support for Code attribute building [v2]
Chen Liang
liach at openjdk.org
Sun Apr 27 03:38:35 UTC 2025
> Internal explicit counter support for Code max_stack and max_locals has been already added in #24807. Since that example works well, we may consider opening this functionality up to general users under strict restrictions.
>
> This is an advanced API; thus, I chose a more complex name `withExplicitStackAndLocals` that discourages accidental use, and indicates the exact order of stack and locals arguments. For integrity, the argument checks are unconditional. And this is also barred behind `DROP_STACK_MAPS` advanced option.
>
> I have enhanced the tests with a `CodeBuilderType` utility to test all types of code builders; it is already effective at increasing coverage in some of our existing tests that only cover DirectCodeBuilder, and simplify other tests. It is particularly helpful for my new `BuilderExplicitMaxsTest`.
Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
Adjust indents
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24903/files
- new: https://git.openjdk.org/jdk/pull/24903/files/e60e3e07..989a494a
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24903&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24903&range=00-01
Stats: 29 lines in 2 files changed: 7 ins; 0 del; 22 mod
Patch: https://git.openjdk.org/jdk/pull/24903.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24903/head:pull/24903
PR: https://git.openjdk.org/jdk/pull/24903
More information about the core-libs-dev
mailing list