RFR: 8355444: [java.io] Use @requires tag instead of exiting based on "os.name" property value [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Apr 28 16:25:46 UTC 2025
On Fri, 25 Apr 2025 16:50:42 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from the `os.name` property and then exiting if the test is not run on that operating system.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8355444: Revert addition of @requires to MacPathTest and add a comment
test/jdk/java/io/FileOutputStream/ManyFiles.java line 42:
> 40: public static void main(String args[]) throws Exception {
> 41: // Vestigial comment from before @requires tag was added:
> 42: // Linux does not yet allow opening this many files; Solaris
Nit - If you do happen to update this PR for any other reason, then maybe consider adding jtreg's `@comment` in the test definition (https://openjdk.org/jtreg/tag-spec.html#INFORMATIONAL_TAGS) just before the `@requires` line and move this existing comment there.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24860#discussion_r2064043079
More information about the core-libs-dev
mailing list