RFR: 8355444: [java.io] Use @requires tag instead of exiting based on "os.name" property value [v4]
Alan Bateman
alanb at openjdk.org
Tue Apr 29 05:41:47 UTC 2025
On Mon, 28 Apr 2025 16:45:01 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Use the `@requires` tag instead of obtaining the operating system name from the `os.name` property and then exiting if the test is not run on that operating system.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8355444: Add comment tag tp ManyFiles
test/jdk/java/io/FileOutputStream/ManyFiles.java line 33:
> 31: * Windows capability it is much simpler to only run it
> 32: * on that platform.
> 33: * @requires (os.family != "linux")
I think this comment should be replaced with a clear summary as to why three is a requires. No need to mention Solaris.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24860#discussion_r2065531220
More information about the core-libs-dev
mailing list