RFR: 8355651: Issues with post-image hook [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Tue Apr 29 13:40:59 UTC 2025


> - Add missing "post-image" infrastructure on Linux.
>  - Fix "post-image" infrastructure on macOS and Windows.
>  - Add relevant tests.
>  - Update TKit to support new tests.

Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains 10 new commits since the last revision:

 - Fix modifiers order
 - Update src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxDebBundler.java
   
   Co-authored-by: Hendrik Schick <30866028+ky0n at users.noreply.github.com>
 - Better test coverage
 - Change signature of TKit.assertEquals(String, String, String) to TKit.assertEquals(Object, Object, String)
 - Add Comm.uniqueEmpty()
 - - Add TKit.assertDirectoryContentRecursive()
   - Fix log messages of TKit.assertDirectoryExists()
 - Reorder actions in PKG packaging to ensure user post-image script is invoked before any PKG is created.
 - Fix formatting
 - - Add missing "post-image" script execution to Linux bundlers
   - Add tests to verify the context of "post-image" script on all platforms
   - Set current directory for "post-image" script on Windows and macOS inside of the app image directory
 - 8355651: Premature execution of post-image hook

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24899/files
  - new: https://git.openjdk.org/jdk/pull/24899/files/ec86bb55..be25c5ce

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24899&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24899&range=00-01

  Stats: 966 lines in 16 files changed: 802 ins; 103 del; 61 mod
  Patch: https://git.openjdk.org/jdk/pull/24899.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24899/head:pull/24899

PR: https://git.openjdk.org/jdk/pull/24899


More information about the core-libs-dev mailing list