RFR: 8355444: [java.io] Use @requires tag instead of exiting based on "os.name" property value [v4]
Brian Burkhalter
bpb at openjdk.org
Tue Apr 29 18:31:38 UTC 2025
On Tue, 29 Apr 2025 16:42:26 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> test/jdk/java/io/FileOutputStream/ManyFiles.java line 33:
>>
>>> 31: * Windows capability it is much simpler to only run it
>>> 32: * on that platform.
>>> 33: * @requires (os.family != "linux")
>>
>> I think this comment should be replaced with a clear summary as to why three is a requires. No need to mention Solaris.
>
> Perhaps the `@requires` tag is no longer needed. Without it, this test passed 30 repeats in the CI on both Intel and ARM Linux nodes.
Comment simplified in 4cee3c2.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24860#discussion_r2067114901
More information about the core-libs-dev
mailing list