RFR: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
Christoph
duke at openjdk.org
Tue Apr 29 18:31:57 UTC 2025
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - It is not clear on which macOS versions codesign fails if application bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG or DMG cannot be generated if signing fails. Exit code of jpackage is ignored, but generated application image will be checked for additional content.
> - This change is for macOS only.
> - Previous implementation of test (forcing expected exist code to 1) was not doing anything useful, since we never checked if additional content was copied or not.
This is unfortunate. However, then how do I add content to the app image before?
Our current workaround is to build an app-image only and then manually pack it but this misses the dmg background images and install instructions etc
https://github.com/JabRef/jabref/blob/97aaab58e3ab543a0f50097ee59e52504d99c786/.github/workflows/deployment.yml#L167-L178
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21698#issuecomment-2839847379
More information about the core-libs-dev
mailing list