RFR: 8352926: New test TestDockerMemoryMetricsSubgroup.java fails [v2]
Sergey Chernyshev
schernyshev at openjdk.org
Tue Apr 29 20:32:52 UTC 2025
On Tue, 29 Apr 2025 14:45:25 GMT, PAWAN CHAWDHARY <duke at openjdk.org> wrote:
>> 8352926: New test TestDockerMemoryMetricsSubgroup.java fails
>
> PAWAN CHAWDHARY has updated the pull request incrementally with one additional commit since the last revision:
>
> update reference of DockerVersion
test/hotspot/jtreg/containers/docker/TestMemoryWithSubgroups.java line 74:
> 72: return;
> 73: }
> 74: if (IS_DOCKER && TestDockerMemoryMetricsSubgroup.DockerVersion.VERSION_20_10_0.compareTo(getDockerVersion()) > 0) {
Should this change also cover Podman, in which the minimum version that supports `--cgroupns` is 3.0 ?
test/jdk/jdk/internal/platform/docker/TestDockerMemoryMetricsSubgroup.java line 149:
> 147: }
> 148:
> 149: private static class DockerVersion implements Comparable<TestDockerMemoryMetricsSubgroup.DockerVersion> {
The same code is added to multiple tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24948#discussion_r2067344723
PR Review Comment: https://git.openjdk.org/jdk/pull/24948#discussion_r2067371874
More information about the core-libs-dev
mailing list