RFR: 8354242: VectorAPI: combine vector not operation with compare [v3]

erifan duke at openjdk.org
Wed Apr 30 01:26:51 UTC 2025


On Tue, 29 Apr 2025 10:22:22 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

> Yes, this discussion is down to `requires` vs `applyIf`. This is my argument for `applyIf`, quoted from above, I have not yet seen an argument against it:
> 
> > If you use @require, then the person does not realize there is a test AND the test is not run. If you use applyIf, the person does not realize there is a test, but it is run at least for result verifiation - and then the person MIGHT realize if the test catches a wrong result / crash.
> 
> In my understanding, `requires` should only be used if the test really **requires** a certain platform or feature. That can be because some flags are only available under certain platforms for example. But for IR tests, we should try to always use `applyIf`, because it allows testing on other platforms.
> 
> Actually, I filed this RFE a while ago: https://bugs.openjdk.org/browse/JDK-8310891 We should try to move as many tests from using `requires` to `applyIf`, so that we have an increased test coverage.

I see, I'll update the code. Thanks~

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24674#issuecomment-2840582699


More information about the core-libs-dev mailing list