RFR: 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe [v2]
Chen Liang
liach at openjdk.org
Wed Apr 30 23:02:24 UTC 2025
On Wed, 26 Mar 2025 16:54:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Chen Liang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>>
>> - Add a test case, fails isWrapperInstance on mainline
>> - Merge branch 'master' of https://github.com/openjdk/jdk into fix/mhp-wrapper-check-async
>> - 8350549: MethodHandleProxies.WRAPPER_TYPES is not thread-safe
>
> Hello Chen, going by what's documented in the `jdk.internal.util.ReferencedKeySet`, the proposed change looks reasonable to me. Someone more familiar with that class and this area in general might have additional inputs. More importantly though, I think this will require a jtreg test to verify that the thread safety in MethodHandleProxies works as expected.
I have successfully created a test case that fails a check due to race condition on mainline. Can you review again, @jaikiran and @JornVernee?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23757#issuecomment-2843623927
More information about the core-libs-dev
mailing list