RFR: 8334238: Enhance AddLShortcutTest jpackage test [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Fri Aug 1 03:13:53 UTC 2025
> - Enhance AddLShortcutTest to cover more combinations of shortcut configurations of the main and additional launchers.
> - Test shortcuts in the predefined app image.
>
> Additionally, rework launcher verification: move launcher icon and shortcut verification code from AdditionalLauncher into LauncherVerifier. This way launcher verification code is encapsulated in a single class that is applied to the main and additional launchers.
>
> Rework launcher shortcut verification on Windows: Read shortcuts from MSI tables. This allows testing of expected and actual shortcuts without installing the MSI. This refactoring removed duplicated checks of file associations: It was performed for every additional launcher; now it is executed for the main launcher only. File association is bound to the main launcher, there is no point to verify it as many times as the number of launchers.
>
> Implement launching launchers through shortcuts on Linux and Windows. The new `AddLShortcutTest.testInvokeShortcuts` test uses this new functionality.
>
> Compared traces of IconTest, AddlauncherTest, and AddLShortcutTest tests with and without this patch to verify no unexpected changes in the coverage.
Alexey Semenyuk has updated the pull request incrementally with three additional commits since the last revision:
- Consistent log message format
- AdditionalLauncher: bugfix
- LauncherShortcut: make it work with the current variant of jpackage without JDK-8308349 mods
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26584/files
- new: https://git.openjdk.org/jdk/pull/26584/files/8d8e7d8f..2d754ee8
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26584&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26584&range=00-01
Stats: 10 lines in 3 files changed: 5 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/26584.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26584/head:pull/26584
PR: https://git.openjdk.org/jdk/pull/26584
More information about the core-libs-dev
mailing list