RFR: 8360037: Refactor ImageReader in preparation for Valhalla support [v12]

Jaikiran Pai jpai at openjdk.org
Fri Aug 1 13:40:05 UTC 2025


On Fri, 1 Aug 2025 13:24:36 GMT, David Beaumont <duke at openjdk.org> wrote:

> "is completed" is a non-directory type, "getLocation() failing" is a non-resource type.

If getLocation() by default throws a `IllegalStateException` stating that the `Node` is not a resource type, then I think it would be more accurate for `isCompleted()` to by default return `false` to match the claim that the `Node` is not a resource type.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26054#discussion_r2248013833


More information about the core-libs-dev mailing list