RFR: 8364361: [process] java.lang.Process should implement close and be AutoCloseable
Francesco Andreuzzi
duke at openjdk.org
Tue Aug 5 18:33:05 UTC 2025
On Tue, 5 Aug 2025 18:21:24 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>
> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>
> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
src/java.base/share/classes/java/lang/Process.java line 663:
> 661: // TBD: Log exceptions closing streams
> 662: IOException ex = new IOException("exception closing process streams");
> 663: exceptions.forEach((e) -> ex.addSuppressed(e));
Suggestion:
exceptions.forEach(ex::addSuppressed);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2255041896
More information about the core-libs-dev
mailing list