RFR: 8364277: (fs) BasicFileAttributes.isDirectory and isOther return true for NTFS directory junctions when links not followed [v2]

[Brian Burkhalter]

On Wed, 6 Aug 2025 01:14:15 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> test/lib/jdk/test/lib/util/libFileUtils.c line 167:
>> 
>>> 165:     lpInBuffer = NULL;
>>> 166: 
>>> 167:     if (result == 0) {
>> 
>> Suggestion: Would it be possible to avoid the dreaded goto
>> 
>> if ((result != 0) && (CloseHandle(hJunction) != 0)) {
>>     return JNI_TRUE;
>> }
>> ...do error handling...
>
>> Would it be possible to avoid the dreaded goto
> 
> I expect so, with some careful editing.

`goto`s removed in 481bdbc.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26631#discussion_r2257848055