RFR: 8364277: (fs) BasicFileAttributes.isDirectory and isOther return true for NTFS directory junctions when links not followed [v3]

Alan Bateman alanb at openjdk.org
Wed Aug 6 18:32:17 UTC 2025


On Wed, 6 Aug 2025 17:34:13 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> src/java.base/windows/classes/sun/nio/fs/WindowsFileAttributes.java line 419:
>> 
>>> 417:             return false;
>>> 418:         return ((fileAttrs & FILE_ATTRIBUTE_DIRECTORY) != 0 &&
>>> 419:                 (fileAttrs & FILE_ATTRIBUTE_REPARSE_POINT) != 0);
>> 
>> Should this just check if reparseTag has the value IO_REPARSE_TAG_MOUNT_POINT?
>
> So changed in 481bdbc.

Thanks for these updates, the src changes look good now. I haven't looked at the test updates yet, will try to get to this soon.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26631#discussion_r2257960839


More information about the core-libs-dev mailing list