RFR: 8364611: (process) Child process SIGPIPE signal disposition should be default [v2]
Thomas Stuefe
stuefe at openjdk.org
Thu Aug 7 06:09:17 UTC 2025
On Wed, 6 Aug 2025 14:04:38 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback Roger
>
> src/java.base/unix/native/libjava/childproc.c line 429:
>
>> 427: }
>> 428:
>> 429: // Childs should be started with default signal disposition for SIGPIPE
>
> Editorial: "Childs" -> Children for plural, "Child" for singular. Here and in tests.
Fixed
> test/jdk/java/lang/ProcessBuilder/childSignalDisposition/exePrintSignalDisposition.c line 60:
>
>> 58: struct sigaction act;
>> 59: if (sigaction(signals[n].sig, NULL, &act) != 0) {
>> 60: perror("sigaction");
>
> The sigaction error message goes to stderr, so it is does not appear in line with the signal name.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26615#discussion_r2259171437
PR Review Comment: https://git.openjdk.org/jdk/pull/26615#discussion_r2259171720
More information about the core-libs-dev
mailing list