RFR: 8308349: missing working directory option for launcher when invoked from shortcuts [v3]
Alexander Matveev
almatvee at openjdk.org
Tue Aug 12 02:18:14 UTC 2025
On Tue, 12 Aug 2025 00:46:44 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> - Support a new "app-dir" value of `win-shortcut`, `win-menu`, and `linux-shortcut` properties in additional launcher property files.
>> - Support an optional value of `--win-shortcut`, `--win-menu`, and `--linux-shortcut` CLI options. The valid value is "app-dir".
>>
>> If a value of any property/CLI option from the above list is set to "app-dir", the startup directory of the corresponding shortcut will be set to the "app" subdirectory of the installation directory.
>>
>> If a CLI option from the above list doesn't have a value, the startup directory of the corresponding shortcut for the main launcher will be set to the installation directory on Windows and will not be set on Linux. This is the existing behavior; it has not changed.
>>
>> If a value of a property from the above list evaluates to `true`, the startup directory of the corresponding shortcut for the additional launcher will be set to the installation directory on Windows and will not be set on Linux. This is the existing behavior; it has not changed.
>>
>> Added test cases to AddLShortcut test implicitly.
>>
>> Reworked one of the additional launchers in AddLShortcut.test() to allow verification of the working directory when the launcher is invoked through the shortcut in manual tests.
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
>
> - Blessed modifiers order
> - Rework AddLShortcutTest.test() to verify the working directory in which one of the additional launchers is started when invoked through a shortcut.
Latest changes looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26707#pullrequestreview-3108337385
More information about the core-libs-dev
mailing list