RFR: 8365436: ImageReaderTest fails when jmods directory not present
David Beaumont
duke at openjdk.org
Thu Aug 14 15:33:16 UTC 2025
On Thu, 14 Aug 2025 09:49:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> Switched from TestSkippedException (not honoured by JUnit) to TestAbortedException (via Assumptions class) to avoid false negative test "failure". Note that now, the test is either shown as skipped, or passed, depending on which report is being looked at. Tweaked error message slightly since using an "exploded image" isn't the only cause.
>
> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 219:
>
>> 217: Helper helper;
>> 218: try {
>> 219: helper = Helper.newHelper();
>
> Suggestion:
>
> boolean isLinkableRuntime = LinkableRuntimeImage.isLinkableRuntime();
> helper = Helper.newHelper(isLinkableRuntime);
>
>
> This will make the test run (not abort) for JEP 493-enabled builds.
Yes, this was done for https://github.com/openjdk/jdk/pull/26774/files once I knew about it and could patch in the extra modules line.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26773#discussion_r2276973796
More information about the core-libs-dev
mailing list