RFR: 8365296: Build failure with Clang due to -Wformat warning after JDK-8364611 [v3]
Guanqiang Han
ghan at openjdk.org
Fri Aug 15 02:24:11 UTC 2025
On Fri, 15 Aug 2025 01:28:39 GMT, Hao Sun <haosun at openjdk.org> wrote:
>> Guanqiang Han has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update exePrintSignalDisposition.c
>>
>> a small fix
>> - Update exePrintSignalDisposition.c
>>
>> Refactor act.sa_mask output
>
> test/jdk/java/lang/ProcessBuilder/childSignalDisposition/exePrintSignalDisposition.c line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
>
> nit: `XX, YY,` means that this file was created in `XX` year and the latest update is done in `YY` year. If `XX == YY`, then use `XX,`.
>
> Suggestion:
>
> * Copyright (c) 2021, 2025, Oracle and/or its affiliates. All rights reserved.
Hi @shqking , thanks for the suggestion! I checked the file history, and it was actually created in 2025. Therefore, I updated the copyright to Copyright (c) 2025 to reflect the correct creation year. If the file gets updated in the future, we can follow the “XX, YY” format.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26771#discussion_r2278090946
More information about the core-libs-dev
mailing list