RFR: 8365296: Build failure with Clang due to -Wformat warning after JDK-8364611 [v3]
Guanqiang Han
ghan at openjdk.org
Fri Aug 15 09:42:17 UTC 2025
On Fri, 15 Aug 2025 06:49:57 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> The fix looks reasonable. However, the discrepancy btw and AIX and others seems unnecessary complexity. I'd prefer having `ifdef` removed also.
>>
>> Looking at how these prints are used/tested, I believe `sa_mask` is not really needed and it doesn't seem very useful also. Therefore, I'd suggest removing it, just like what's done for AIX. My 2c.
>
>> The fix looks reasonable. However, the discrepancy btw and AIX and others seems unnecessary complexity. I'd prefer having `ifdef` removed also.
>>
>> Looking at how these prints are used/tested, I believe `sa_mask` is not really needed and it doesn't seem very useful also. Therefore, I'd suggest removing it, just like what's done for AIX. My 2c.
>
> That's fine .
Many thanks to both of you @MBaesken @albertnetymk for your review and approval. I’ve integrated the changes.
Please sponsor it — appreciate it!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26771#issuecomment-3191107779
More information about the core-libs-dev
mailing list