RFR: 8360559: Optimize Math.sinh for x86 64 bit platforms [v3]

Emanuel Peter epeter at openjdk.org
Tue Aug 19 08:14:46 UTC 2025


On Mon, 4 Aug 2025 19:47:32 GMT, Mohamed Issa <missa at openjdk.org> wrote:

>> This seems to be failing in the CI on the build of: linux-x64-debug-nopch
>> 
>> [2025-08-04T19:02:29,373Z] /......../workspace/open/src/hotspot/cpu/x86/stubGenerator_x86_64_sinh.cpp:293:27: error: 'stub_id' was not declared in this scope; did you mean 'StubId'?
>> [2025-08-04T19:02:29,373Z]   293 |   StubCodeMark mark(this, stub_id);
>> [2025-08-04T19:02:29,373Z]       |                           ^~~~~~~
>> [2025-08-04T19:02:29,373Z]       |                           StubId
>> [2025-08-04T19:02:29,373Z]
>
>> This seems to be failing in the CI on the build of: linux-x64-debug-nopch
>> 
>> ```
>> [2025-08-04T19:02:29,373Z] /......../workspace/open/src/hotspot/cpu/x86/stubGenerator_x86_64_sinh.cpp:293:27: error: 'stub_id' was not declared in this scope; did you mean 'StubId'?
>> [2025-08-04T19:02:29,373Z]   293 |   StubCodeMark mark(this, stub_id);
>> [2025-08-04T19:02:29,373Z]       |                           ^~~~~~~
>> [2025-08-04T19:02:29,373Z]       |                           StubId
>> [2025-08-04T19:02:29,373Z] 
>> ```
> 
> Thanks for notification. It looks like an incorrect type declaration. I'll submit a fix.

@missa-prime I was on vacation for a few weeks. Feel free to ping others when I don't respond ;)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26152#issuecomment-3199712429


More information about the core-libs-dev mailing list