RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v9]
Daniel Jeliński
djelinski at openjdk.org
Tue Aug 19 10:10:01 UTC 2025
On Tue, 1 Jul 2025 11:13:44 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 525 commits:
>>
>> - merge latest changes from master branch
>> - http3: run H3StreamLimitReachedTest.java with -Djdk.httpclient.http3.maxStreamLimitTimeout=0 too
>> - retry the ResetControlStream test as needed
>> - http3: fix pending connection and reconnection on stream limit reached logic
>> - http3: pending acknowledgement should be registered before actually sending the packet
>> - http3: fix race with ping requests in PacketSpaceManager.java causing intermittent failures in H3ErrorHandlingTest.java
>> - http3: improve exceptions in Http3ServerExchange.java
>> - http3: fix exception handling in CancelRequestTest.java
>> - http3: review feedback - revert HPACK.java
>> - Implement X509TrustManagerImpl#checkClientTrusted for QUIC
>> - ... and 515 more: https://git.openjdk.org/jdk/compare/5a1301df...0229c215
>
> src/java.net.http/share/classes/jdk/internal/net/http/http3/frames/FramesDecoder.java line 143:
>
>> 141: * This method doesn't try to do any decoding.
>> 142: */
>> 143: public Http3Frame peek() {
>
> This method is unused. I'll remove it.
Addressed in fe4073ca4939e9870924cfc54f1d6e6091642af3
> src/java.net.http/share/classes/jdk/internal/net/http/http3/streams/UniStreamPair.java line 87:
>
>> 85: private final CompletableFuture<QuicStreamWriter> streamWriterCF;
>> 86: // a queue of ByteBuffers submitted for writing.
>> 87: // might be null if not used. Only used in QueuingStreamPair.
>
> It seems to be true. I'll see if I can move it to QueuingStreamPair.
Moved in c2a351ed5cdcaa5c0bdf7e28140a1dfb4e751d56 + 91fb530b350f733789c4deae53c83855d00365b6
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2284775186
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2284771544
More information about the core-libs-dev
mailing list