RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v11]
Daniel Fuchs
dfuchs at openjdk.org
Tue Aug 19 14:48:09 UTC 2025
On Thu, 24 Jul 2025 12:21:56 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 550 commits:
>>
>> - merge latest changes from master branch
>> - http3: fix new HttpHeadersBuilder constructor
>> - qpack - optimize processing of decoder instruction exceptions
>> - http3/quic: update the code to use the newly introduced jdk.internal.net.http.Origin
>> - Avoid speculating about the future in TODOs
>> - http3: rename PacketSpaceManager::isAcknowledging to PacketSpaceManager::trackAcknowledgement
>> - merge latest changes from master branch
>> - http3: fix typo in UniStreamPair.java
>> - WriterQueue may leak before the constructor completes
>> - Limit the number of retries in H3UserInfoTest
>> - ... and 540 more: https://git.openjdk.org/jdk/compare/7b255b8a...f0a4fd3d
>
> test/jdk/java/net/httpclient/http3/BadCipherSuiteErrorTest.java line 59:
>
>> 57: * causing hang problems
>> 58: */
>> 59: public class BadCipherSuiteErrorTest implements HttpServerAdapters {
>
> This test overlaps with H3QuicTLSConnection test. Any reason to keep them separate?
http3/BadCipherSuiteErrorTest is a clone of http2/ErrorTest - adapted to replace HTTP/2 specifics with HTTP/3.
The original ErrorTest test had been introduced as a non regression test for JDK-8157105.
I guess we could consider merging BadCipherSuiteErrorTest with H3QuicTLSConnection if we are sure that path is covered. I have logged https://bugs.openjdk.org/browse/JDK-8365800
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2285508994
More information about the core-libs-dev
mailing list