RFR: 8365703: Refactor ZipCoder to use common JLA.uncheckedNewStringNoRepl
Lance Andersen
lancea at openjdk.org
Tue Aug 19 16:04:39 UTC 2025
On Mon, 18 Aug 2025 15:31:21 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
> Simplify JLA by changing ZipCoder to use JLA.uncheckedNewStringNoRepl(byte[] bytes, Charset cs) instead of the JLA.newStringUTF8NoRepl.
> A copy of the bytes is made so it can be exclusively used to create the string. The "shared" flag is no longer needed in String.newStringUTF8NoRepl.
I think the changes look good as ZipFile.Source::checkAndAddEntry should still throw a ZipException with this change
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26822#pullrequestreview-3132960064
More information about the core-libs-dev
mailing list