RFR: 8365703: Refactor ZipCoder to use common JLA.uncheckedNewStringNoRepl [v3]

[Volkan Yazici]

On Tue, 19 Aug 2025 19:24:51 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Simplify JLA by changing ZipCoder to use JLA.uncheckedNewStringNoRepl(byte[] bytes, Charset cs) instead of the JLA.newStringUTF8NoRepl.
>> A copy of the bytes is made so it can be exclusively used to create the string. The "shared" flag is no longer needed in String.newStringUTF8NoRepl.
>
> Roger Riggs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge
>  - Flesh out javadoc in src/java.base/share/classes/java/lang/String.java
>    
>    Co-authored-by: Volkan Yazıcı <volkan.yazici at oracle.com>
>  - 8365703: Refactor ZipCoder to use common JLA.uncheckedNewStringNoRepl
>    
>    Simplify JLA by changing ZipCoder to use JLA.uncheckedNewStringNoRepl(byte[] bytes, Charset cs)
>    instead of the JLA.newStringUTF8NoRepl.
>    A copy of the bytes is made so it can be exclusively used to create the string.
>    The "shared" flag is no longer needed in String.newStringUTF8NoRepl.

Marked as reviewed by vyazici (Committer).

src/java.base/share/classes/java/lang/String.java line 696:

> 694:      * the string and is not modified or used for any other purpose.
> 695:      */
> 696:     static String newStringUTF8NoRepl(byte[] bytes, int offset, int length) {

@RogerRiggs, `/integrate` has failed due to merge conflict. While you're at it, you might consider making this method `private`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26822#pullrequestreview-3133624472
PR Review Comment: https://git.openjdk.org/jdk/pull/26822#discussion_r2286184625