RFR: 8365186: Reduce size of j.t.f.DateTimePrintContext::adjust [v4]
Shaojin Wen
swen at openjdk.org
Thu Aug 21 01:30:52 UTC 2025
> By adding the JVM startup parameters `-XX:+UnlockDiagnosticVMOptions -XX:+PrintInlining` and analyzing the printed log information, and found that the code size of the j.t.f.DateTimePrintContext::adjust method is 382, which is greater than 325, causing inlining failure.
>
>
> @ 7 java.time.format.DateTimePrintContext::adjust (382 bytes) failed to inline: hot method too big
>
>
> By splitting the code into `common/uncommon`, and moving the uncommon code into adjust0, the adjust method is kept small and can be inlined by the C2 optimizer.
Shaojin Wen has updated the pull request incrementally with two additional commits since the last revision:
- code style
- implNote before param, from @RogerRiggs
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26633/files
- new: https://git.openjdk.org/jdk/pull/26633/files/22ae4c83..2439770d
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26633&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26633&range=02-03
Stats: 12 lines in 1 file changed: 2 ins; 7 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/26633.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26633/head:pull/26633
PR: https://git.openjdk.org/jdk/pull/26633
More information about the core-libs-dev
mailing list