RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v3]
Jaikiran Pai
jpai at openjdk.org
Tue Aug 26 05:37:49 UTC 2025
> Can I please get a review of this trivial change to the `ModuleDescriptor.packages()` method's specification?
>
> The change here clarifies that this method returns all packages that belong to the module and not just those that are exported or open. This clarification should help avoid any confusion that may have been caused by the second paragraph in that method's specification which talks about exported and open packages.
>
> This updated specification matches the existing implementation of this method.
>
> I believe this will require a CSR, which I'll create shortly.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
Alan's review
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/26928/files
- new: https://git.openjdk.org/jdk/pull/26928/files/413d4f2e..70452c31
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=26928&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=26928&range=01-02
Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/26928.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26928/head:pull/26928
PR: https://git.openjdk.org/jdk/pull/26928
More information about the core-libs-dev
mailing list