RFR: 8365898: Specification of java.lang.module.ModuleDescriptor.packages() method can be improved [v3]
Chen Liang
liach at openjdk.org
Thu Aug 28 17:19:42 UTC 2025
On Tue, 26 Aug 2025 05:37:49 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this trivial change to the `ModuleDescriptor.packages()` method's specification?
>>
>> The change here clarifies that this method returns all packages that belong to the module and not just those that are exported or open. This clarification should help avoid any confusion that may have been caused by the second paragraph in that method's specification which talks about exported and open packages.
>>
>> This updated specification matches the existing implementation of this method.
>>
>> I believe this will require a CSR, which I'll create shortly.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> Alan's review
Revised wording looks good.
-------------
Marked as reviewed by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26928#pullrequestreview-3165788232
More information about the core-libs-dev
mailing list