RFR: 8365467: Fix multiple issues in ExplodedImage
David Beaumont
duke at openjdk.org
Fri Aug 29 08:37:42 UTC 2025
On Wed, 13 Aug 2025 12:23:33 GMT, David Beaumont <duke at openjdk.org> wrote:
>> This PR addresses several issues found while adding unit tests for ExplodedImage.
>> I have added review comments for changes (some of which are a little preferential, but bring the code into line with things like ImageReader in terms of the name choices for variables).
>> Later it is likely that this code will be adapted for the up-coming preview mode support in Valhalla, so having it unit-testable is important.
>
> src/java.base/share/classes/jdk/internal/jrtfs/ExplodedImage.java line 95:
>
>> 93: }
>> 94:
>> 95: @Override
>
> Discovered this method was missing during testing. I *think* this logic is what's needed here, but I would like someone to just double check.
Is that thumbs up and confirmation that you've checked it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26757#discussion_r2309542199
More information about the core-libs-dev
mailing list