RFR: 8365467: Issues with jrtfs implementation for exploded run-time images [v2]
Chen Liang
liach at openjdk.org
Sat Aug 30 14:29:46 UTC 2025
On Fri, 29 Aug 2025 08:49:27 GMT, David Beaumont <duke at openjdk.org> wrote:
>> This PR addresses several issues found while adding unit tests for ExplodedImage.
>> I have added review comments for changes (some of which are a little preferential, but bring the code into line with things like ImageReader in terms of the name choices for variables).
>> Later it is likely that this code will be adapted for the up-coming preview mode support in Valhalla, so having it unit-testable is important.
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>
> Feedback tweaks.
Requesting changes for the isResource update.
-------------
Changes requested by liach (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26757#pullrequestreview-3171059246
More information about the core-libs-dev
mailing list