RFR: 8372787: ModuleReader should throw IOException consistently when using --patch-module and ModuleReader is closed [v6]

Joe Darcy darcy at openjdk.org
Mon Dec 1 17:14:01 UTC 2025


On Mon, 1 Dec 2025 16:44:06 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/JDK-8372787?
>> 
>> The commit in this PR updates several methods in the `jdk.internal.module.ModulePatcher$PatchedModuleReader` to throw an `IOException` if the `ModuleReader` has been closed. This updated implementation now matches the specification of the corresponding methods in `ModuleReader`.
>> 
>> A new jtreg test has been introduced to reproduce the issue and verify the fix. CI testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Alan's suggestion - additional tests to the found resource URI

Does this behavior change merit CSR review?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28569#issuecomment-3597805989


More information about the core-libs-dev mailing list