RFR: 8372787: ModuleReader should throw IOException consistently when using --patch-module and ModuleReader is closed [v7]
Alan Bateman
alanb at openjdk.org
Tue Dec 2 08:18:54 UTC 2025
On Tue, 2 Dec 2025 06:58:51 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/JDK-8372787?
>>
>> The commit in this PR updates several methods in the `jdk.internal.module.ModulePatcher$PatchedModuleReader` to throw an `IOException` if the `ModuleReader` has been closed. This updated implementation now matches the specification of the corresponding methods in `ModuleReader`.
>>
>> A new jtreg test has been introduced to reproduce the issue and verify the fix. CI testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision:
>
> - return early if already closed()
> - fix summary line
> - even test for ModuleReader.list() on a closed ModuleReader
Marked as reviewed by alanb (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28569#pullrequestreview-3528805026
More information about the core-libs-dev
mailing list