RFR: 8347831: Re-examine version check when cross linking [v8]
Alan Bateman
alanb at openjdk.org
Tue Dec 2 16:19:22 UTC 2025
On Tue, 2 Dec 2025 15:36:46 GMT, Henry Jen <henryjen at openjdk.org> wrote:
>>> It might be useful to see what breaks if a JDK were built with a newline in the vendor name, I assume other things will break.
>>
>> Writhing the manifest entries for `jrt-fs.jar` break (header validation fails). Since the vendor populates to that jar file.
>
> The CSR is approved, and the one line signature is in the text.
> And since other things break with newline in the vendor name, I assume that vendor name is also limited, so are we good with current implementation?
> Are we suggesting to add error message when there is more than one line? I think current implementation is fine.
I don't think we need to be concerned with this right now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28155#discussion_r2581908452
More information about the core-libs-dev
mailing list