RFR: 8356116: [macos] Add logging of sign commands in jpackage
Alexander Matveev
almatvee at openjdk.org
Wed Dec 3 03:29:14 UTC 2025
- Added logging of sign commands.
- Sign commands will be logged with `DEBUG` level. Skipped files and signature removal with `TRACE` to reduce amount of less important messages.
- Renamed `unsign` to `removeSignature`. I think it is better name.
- Removed `sign` and `codesigners.accept(path)` will be used instead. Not sure why we need function with one line and we using `codesigners.accept(path)` in other places anyway.
- Direct call to `codesigners.codesignDir().accept(path)` was changed to `codesigners.accept(path)`. In this case exception will be logged if `codesignDir` is not available and I think it is better for `codesigners.accept(path)` to select code signer vs calling it directly.
-------------
Commit messages:
- 8356116: [macos] Add logging of sign commands in jpackage
Changes: https://git.openjdk.org/jdk/pull/28623/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28623&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8356116
Stats: 154 lines in 6 files changed: 112 ins; 32 del; 10 mod
Patch: https://git.openjdk.org/jdk/pull/28623.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28623/head:pull/28623
PR: https://git.openjdk.org/jdk/pull/28623
More information about the core-libs-dev
mailing list