RFR: 8356116: [macos] Add logging of sign commands in jpackage
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Dec 3 15:26:45 UTC 2025
On Wed, 3 Dec 2025 03:20:45 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - Added logging of sign commands.
> - Sign commands will be logged with `DEBUG` level. Skipped files and signature removal with `TRACE` to reduce amount of less important messages.
> - Renamed `unsign` to `removeSignature`. I think it is better name.
> - Removed `sign` and `codesigners.accept(path)` will be used instead. Not sure why we need function with one line and we using `codesigners.accept(path)` in other places anyway.
> - Direct call to `codesigners.codesignDir().accept(path)` was changed to `codesigners.accept(path)`. In this case exception will be logged if `codesignDir` is not available and I think it is better for `codesigners.accept(path)` to select code signer vs calling it directly.
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageSigner.java line 92:
> 90: boolean result = testInternal(path);
> 91: LOGGER.log(Level.TRACE, "{0}: {1}", path, result ?
> 92: "Will be explicitely signed" : "Will be skipped from signing");
We will have detailed log statements for files that will be signed, right? We don't need an extra "Will be explicitely signed" log message for these files. I think "Will be skipped from signing" is sufficient for files that will be skipped in signing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28623#discussion_r2585555883
More information about the core-libs-dev
mailing list