RFR: 8372844: Improve usage of test/jdk/java/text/testlib/TestUtils.java locale methods [v2]
Naoto Sato
naoto at openjdk.org
Wed Dec 3 17:07:22 UTC 2025
On Tue, 2 Dec 2025 19:14:02 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> This PR updates the call sites of `TestUtils::usesGregorianCalendar`, `TestUtils::usesAsciiDigits`, and `TestUtils::hasSpecialVariant` to use `Assumptions` to properly abort the test.
>>
>> The existing usage of these methods involve printing to output and returning when locale conditions are not met. Some of these tests do lots of printing, so identifying when a test is skipped due to inadequate locale conditions may not be obvious. Instead of simply printing to output, it would be better for test diagnostics to abort the tests, which is easy to identify in the Jtreg output. E.g.
>>
>>> [ JUnit Tests: found 1189, started 1189, succeeded 1185, failed 0, aborted 4, skipped 0]
>>
>> As a result of this change, Bug4407042, Bug4845901, Bug6530336, and LocaleCategory were converted to JUnit based tests. (I could have decided to throw jtreg.SkippedException for those tests, but decided to just convert as well.)
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>
> Reflect Naoto's comments
LGTM
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28590#pullrequestreview-3536085126
More information about the core-libs-dev
mailing list