RFR: 8371871: libSharedCloseAgent.cpp crashes VS2019 and older VS2022 compiler

[Jorn Vernee]

On Wed, 10 Dec 2025 10:12:07 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> test\jdk\java\foreign\sharedclosejvmti\libSharedCloseAgent.cpp fails with VS2019 and some versions of VS2022 compilers as follows
> 
> 
> ========================8<------------------------
> * For target support_test_jdk_jtreg_native_support_libSharedCloseAgent_libSharedCloseAgent.obj:
> libSharedCloseAgent.cpp
> z:\BuildAgent\work\23f345c5c4b56004\test\jdk\java\foreign\sharedclosejvmti\libSharedCloseAgent.cpp(105): fatal error C1001: Internal compiler error.
> (compiler file 'msc1.cpp', line 1603)

Marked as reviewed by jvernee (Reviewer).

test/jdk/java/foreign/sharedclosejvmti/libSharedCloseAgent.cpp line 106:

> 104: 
> 105:   jvmtiCapabilities capabilities;
> 106:   memset(&capabilities, 0, sizeof(jvmtiCapabilities));

I used `{}` to zero initialize all the fields of this struct. I see other use cases are also using `memset` to zero out the struct.

-------------

PR Review: https://git.openjdk.org/jdk/pull/28739#pullrequestreview-3562554074
PR Review Comment: https://git.openjdk.org/jdk/pull/28739#discussion_r2606668513