RFR: 8370863: VectorAPI: Optimize the VectorMaskCast chain in specific patterns [v2]

[Emanuel Peter]

On Thu, 4 Dec 2025 02:23:40 GMT, Eric Fang <erfang at openjdk.org> wrote:

>> src/hotspot/share/opto/vectornode.cpp line 1056:
>> 
>>> 1054: //   x remains to be a bool vector with no changes.
>>> 1055: // This function can be used to eliminate the VectorMaskCast in such patterns.
>>> 1056: Node* VectorNode::uncast_mask(Node* n) {
>> 
>> Could this be a static method instead?
>
> Yeah it's already a static method. See https://github.com/openjdk/jdk/pull/28313/files#diff-ba9e2d10a50a01316946660ec9f68321eb864fd9c815616c10abbec39360efe5R141 
> 
> Or you mean a static method limited to this file ? If so, I prefer not, it may be used at other places. Thanks~

Could you return a `VectorNode*`? And should the input not already be a `VectorNode*`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28313#discussion_r2614565511