RFR: 8341914: The j.u.Formatter doc for TemporalAccessor should be enhanced [v4]

Raffaello Giulietti rgiulietti at openjdk.org
Fri Dec 12 18:57:54 UTC 2025


On Fri, 12 Dec 2025 17:35:40 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Raffaello Giulietti has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove unused import.
>
> src/java.base/share/classes/java/util/Formatter.java line 442:
> 
>> 440:  *     Not all subtypes of {@link TemporalAccessor} carry a time zone, though,
>> 441:  *     so in such cases this conversion throws an {@link IllegalFormatConversionException}.
>> 442:  *
> 
> A more complete description would helpful before the table at line 388 and also
> just after the mention of TemporalAccessor at line 1627, I'd suggest a sentence or paragraph with something like: 
> 
> The `java.time` types such as `LocalDateTime `or `MonthDay` are TemporalAccessors. 
> Each of the formatting character uses fields from the TemporalAccessor but not all accessors have all of the field. For example, the timezone is not available from LocalDateTime.  If a field is not available an IllegalFormatConversionException is thrown.

After a deeper look, it seems to me that what happens with `long` and `Long` used in date/time conversions is not detailed at all 🤔.
So expect more thorough patch for date/time related conversions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27830#discussion_r2615255683


More information about the core-libs-dev mailing list