RFR: 8373631: Improve classes in the "jdk.jpackage.internal.util.function" package [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Sun Dec 14 05:08:52 UTC 2025
> - Add exception type as an additional generic parameter to all `Throwing...` interfaces
> - Add unit tests for "jdk.jpackage.internal.util.function" package
> - Add `ExceptionBox.toUnchecked()`. It is equivalent to `ExceptionBox.rethrowUnchecked()`, but doesn't throw
> - Replace `ExceptionBox.rethrowUnchecked(...)` with `ExceptionBox.toUnchecked(...)`; this increased test coverage of "jdk.jpackage.internal.util.function" package from 86% to 97%
> - Change exception handling in `ExceptionBox.toUnchecked()` (former `ExceptionBox.rethrowUnchecked()`):
> - `InterruptedException`: instead of rethrowing an exception of this type, it calls `Thread.currentThread().interrupt()` and then rethrows it
> - Add `ExceptionBox.unbox()` (former `TKit.unbox()`). It is complementary to `ExceptionBox.toUnchecked()`
> - Catch `Exception` instead of `Throwable` where appropriate to avoid catching `Error`-s. The idea is not to handle fatal errors
> - Replace vague `throws Throwable` exception specifications with more specific ones where appropriate
> - Add `ExceptionBox.reachedUnreachable()` for use in locations that control flow is not expected to reach
Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
TKit: fix missing test execution summary if some tests fail
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28731/files
- new: https://git.openjdk.org/jdk/pull/28731/files/715c5ac5..c56b5350
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28731&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28731&range=00-01
Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/28731.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28731/head:pull/28731
PR: https://git.openjdk.org/jdk/pull/28731
More information about the core-libs-dev
mailing list