RFR: 8373798: Refactor java/math tests to use JUnit

Raffaello Giulietti rgiulietti at openjdk.org
Tue Dec 16 15:07:45 UTC 2025


On Tue, 16 Dec 2025 14:59:35 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Replace testng framework with junit
>
> test/jdk/java/math/BigDecimal/Constructor.java line 71:
> 
>> 69:                 } else {
>> 70:                     throw nfe;
>> 71:                 }
> 
> If you want, you could use `NumberFormatException nfe = assertThrows(..)` here, then assert the cause. That would avoid mixing JUnit asserts with explicit throw of RuntimeException.

That's just the result of a mechanical conversion of the original testng-based code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28848#discussion_r2623658294


More information about the core-libs-dev mailing list