RFR: 8373661: Add edge case tests for Objects.requireNonNull methods [v5]
eunbin son
duke at openjdk.org
Thu Dec 18 11:54:41 UTC 2025
> ## Summary
> Adds comprehensive edge case tests for `Objects.requireNonNull`,
> `requireNonNullElse`, and `requireNonNullElseGet` methods to improve
> test coverage.
>
> ## Problem
> The current test suite for `Objects.requireNonNull` methods covers
> basic cases but lacks edge case coverage.
>
> ## Solution
> This PR adds tests for the following edge cases:
> - requireNonNull with null Supplier parameter
> - requireNonNull with Supplier that throws exception
> - requireNonNullElse with both arguments null
> - requireNonNullElseGet with null supplier
> - requireNonNullElseGet with supplier returning null
>
> ## Issue
> Fixes JDK-8373661
>
> **JBS Issue Link**: https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8373661
>
> ## Type of Change
> - [x] Test addition/modification
> - [ ] Bug fix
> - [ ] New feature
> - [ ] Documentation improvement
> - [ ] Refactoring
>
> ## Testing
>
> make test TEST="jtreg:test/jdk/java/util/Objects"
eunbin son has updated the pull request incrementally with one additional commit since the last revision:
8373661: Address code style feedback
- Expanded wildcard imports to individual imports
- Simplified test messages to identify tests only
- Used Assertions.fail() where appropriate
- Kept assertTrue/assertFalse for isNull API tests
Thanks to @RogerRiggs and @liach for the feedback.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28845/files
- new: https://git.openjdk.org/jdk/pull/28845/files/3986ed4b..11d7aae7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28845&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28845&range=03-04
Stats: 26 lines in 1 file changed: 11 ins; 6 del; 9 mod
Patch: https://git.openjdk.org/jdk/pull/28845.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28845/head:pull/28845
PR: https://git.openjdk.org/jdk/pull/28845
More information about the core-libs-dev
mailing list