RFR: 8373661: Add edge case tests for Objects.requireNonNull methods [v5]
Roger Riggs
rriggs at openjdk.org
Fri Dec 19 17:05:01 UTC 2025
On Thu, 18 Dec 2025 11:54:41 GMT, eunbin son <duke at openjdk.org> wrote:
>> ## Summary
>> Adds comprehensive edge case tests for `Objects.requireNonNull`,
>> `requireNonNullElse`, and `requireNonNullElseGet` methods to improve
>> test coverage.
>>
>> ## Problem
>> The current test suite for `Objects.requireNonNull` methods covers
>> basic cases but lacks edge case coverage.
>>
>> ## Solution
>> This PR adds tests for the following edge cases:
>> - requireNonNull with null Supplier parameter
>> - requireNonNull with Supplier that throws exception
>> - requireNonNullElse with both arguments null
>> - requireNonNullElseGet with null supplier
>> - requireNonNullElseGet with supplier returning null
>>
>> ## Issue
>> Fixes JDK-8373661
>>
>> **JBS Issue Link**: https://bugs.java.com/bugdatabase/view_bug?bug_id=JDK-8373661
>>
>> ## Type of Change
>> - [x] Test addition/modification
>> - [ ] Bug fix
>> - [ ] New feature
>> - [ ] Documentation improvement
>> - [ ] Refactoring
>>
>> ## Testing
>>
>> make test TEST="jtreg:test/jdk/java/util/Objects"
>
> eunbin son has updated the pull request incrementally with one additional commit since the last revision:
>
> 8373661: Address code style feedback
>
> - Expanded wildcard imports to individual imports
> - Simplified test messages to identify tests only
> - Used Assertions.fail() where appropriate
> - Kept assertTrue/assertFalse for isNull API tests
>
> Thanks to @RogerRiggs and @liach for the feedback.
The copyright date needs to be updated to 2025.
Tests should be as readable and maintainable as the other source code.
The coding styles vary a bit, having accumulated by many authors over the years.
Changes should follow the existing coding style in the file, package, module, etc.
The changes look good; thanks for taking on the JUnit conversion and the addition of tests.
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28845#pullrequestreview-3599377100
More information about the core-libs-dev
mailing list