RFR: 8373718: jdk/internal/misc/VM/RuntimeArguments.java test fails in Virtual threads mode [v2]
Brent Christian
bchristi at openjdk.org
Fri Dec 19 22:07:37 UTC 2025
> `RuntimeArguments.java` runs with `@requires vm.flagless`, though setting the `test.thread.factory=Virtual` system property with `-D` will still run the test.
>
> The test spawns java processes, checking for particular, exact sets of runtime options (hence, `vm.flagless`). It is not expecting to find `-Dtest.thread.factory=Virtual`.
>
> It doesn't seem important that this test be run with the virtual thread factory. The suggestion of adding this test to `ProblemList-Virtual.txt` seems reasonable. (It would be a long term resident of the problem list, which is perhaps a bit strange.)
>
> Alternative courses of action:
> * Teach the test itself to artificially pass in the presence of `-D` options.
> * Enhance the test so it knows how to expect `-D` options; offhand that doesn't seem worth it.
Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
Change ProblemList bugid to 8309303
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28935/files
- new: https://git.openjdk.org/jdk/pull/28935/files/e14a1cec..2483e66e
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28935&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28935&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/28935.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28935/head:pull/28935
PR: https://git.openjdk.org/jdk/pull/28935
More information about the core-libs-dev
mailing list