RFR: 8373661: Add edge case tests for Objects.requireNonNull methods [v7]
eunbin son
duke at openjdk.org
Mon Dec 22 03:24:01 UTC 2025
On Sun, 21 Dec 2025 23:41:42 GMT, Florent Guillaume <duke at openjdk.org> wrote:
>> eunbin son has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8373661: Address liach's feedback on copyright year and redundant messages
>>
>> I apologize for the earlier incorrect implementation. As @liach noted,
>> "I asked to run a command to fix the copyright year and to remove
>> redundant message, both of which are done incorrectly." I have now
>> properly addressed both concerns:
>>
>> - Copyright year: Updated to 2025 (the copyright year was already set
>> in the previous commit, but I should have used the
>> update_copyright_year.sh script as requested)
>>
>> - Redundant messages: Removed all exception message tests, verbose
>> inline comments, and simplified all test messages to use only test
>> method names
>>
>> Thanks to @liach for the detailed feedback.
>
> So much time and power extended on reviewing a PR for one test file whose update changes essentially nothing to the JDK... Using AI tools on the JDK for no other purpose than using AI...
> There are other priorities imho.
> This PR should be closed for lack of relevance.
Thank you for the review and for pointing out the priority concerns. @efge
My intention was simply to make a small, good-faith contribution to the JDK test code, not to add review burden or to promote the use of AI tools. I understand if this change is not considered relevant.
I appreciate the time you’ve already spent on this. @liach @RogerRiggs
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28845#issuecomment-3680215142
More information about the core-libs-dev
mailing list