RFR: 8374216: Assorted changes to jpackage without functional impact [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Mon Dec 22 23:47:54 UTC 2025
On Mon, 22 Dec 2025 22:15:13 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Miscellaneous refactorings without functional changes:
>>
>> - Replace StringBuffer with StringBuilder where appropriate
>> - LauncherBuilder: set reasonable defaults to "defaultIconResourceName" property; move `defaultIconResourceName()` from LauncherFromOptions
>> - Make `MacHelper.createRuntimeBundle()` use PackageTest to create a runtime bundle. Will use DMG by default and optionally PKG packaging to create a runtime bundle
>> - Remove redundat parameter from `SetBuilder.build()`
>> - Make `JUnitUtils.assertArrayEquals()` permit null-s
>> - Add `JPackageCommand.withToolProvider()`
>> - Make some handy package-private methods in StandardBundlingOperation class public
>> - BundleSpec: add "sealed" modifier
>> - IdentityWrapper: add `wrapIdentity()`
>> - Simplify `DefaultBundlingEnvironment.createNativePackage()`
>> - TKit: remove "throws IOException" from `createDirectories()`; Replace `TKit.createDirectories()` with `Files.createDirectories()` where directory clean-up is not used
>
> Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>
> - Use Files.createDirectories() instead of TKit.createDirectories() where automatic clean-up functionality is not used
> - DefaultBundlingEnvironment: change the signature of createNativePackage()
@sashamatveev PTAL
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28957#issuecomment-3684561846
More information about the core-libs-dev
mailing list