RFR: 8374216: Assorted changes to jpackage without functional impact [v3]

Alexey Semenyuk asemenyuk at openjdk.org
Tue Dec 23 00:01:48 UTC 2025


> Miscellaneous refactorings without functional changes:
> 
> - Replace StringBuffer with StringBuilder where appropriate
> - LauncherBuilder: set reasonable defaults to "defaultIconResourceName" property; move `defaultIconResourceName()` from LauncherFromOptions
> - Make `MacHelper.createRuntimeBundle()` use PackageTest to create a runtime bundle. Will use DMG by default and optionally PKG packaging to create a runtime bundle
> - Remove redundat parameter from `SetBuilder.build()`
> - Make `JUnitUtils.assertArrayEquals()` permit null-s
> - Add `JPackageCommand.withToolProvider()`
> - Make some handy package-private methods in StandardBundlingOperation class public
> - BundleSpec: add "sealed" modifier
> - IdentityWrapper: add `wrapIdentity()`
> - Simplify `DefaultBundlingEnvironment.createNativePackage()`
> - TKit: remove "throws IOException" from `createDirectories()`; Replace `TKit.createDirectories()` with `Files.createDirectories()` where directory clean-up is not used

Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:

 - Use Files.createDirectories() instead of TKit.createDirectories() where automatic clean-up functionality is not used
 - DefaultBundlingEnvironment: change the signature of createNativePackage()
 - DefaultBundlingEnvironment: better error message in getBundlerSupplier()
 - TKit: remove "throws IOException" from createDirectories()
 - IdentityWrapper: add wrapIdentity()
 - BundleSpec: add "sealed"
 - PackageType: follow-up for BundlingOperationDescriptor changes; ignore errors when the service loader can't find BundlingEnvironment instance.
 - StandardBundlingOperation: make handy package-private methods public, add Verb enum
 - BundlingOperationDescriptor: add VERB_CREATE_BUNDLE, add another ctor
 - JPackageCommand: add withToolProvider()
 - ... and 5 more: https://git.openjdk.org/jdk/compare/4b8eda30...5d43b18f

-------------

Changes: https://git.openjdk.org/jdk/pull/28957/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28957&range=02
  Stats: 234 lines in 25 files changed: 120 ins; 41 del; 73 mod
  Patch: https://git.openjdk.org/jdk/pull/28957.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28957/head:pull/28957

PR: https://git.openjdk.org/jdk/pull/28957


More information about the core-libs-dev mailing list