RFR: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null

Jaikiran Pai jpai at openjdk.org
Mon Feb 3 15:53:17 UTC 2025


Can I please get a review of this change which backs out the commit that was introduced for https://bugs.openjdk.org/browse/JDK-8333893?

The comment in the PR review of that issue https://github.com/openjdk/jdk/pull/19626#issuecomment-2628937397 explains what the issue is with the change that was integrated.

This backout was done using `git revert 5890d9438bbde88b89070052926a2eafe13d7b42`, but the the revert wasn't clean and I had to resolve a trivial conflict in `StringLatin1.java`.

tier1, tier2 and tier3 testing is currently in progress with this change. Once this is integrated into mainline, a corresponding backport will be done to `jdk24` branch with the requisite approvals.

-------------

Commit messages:
 - Revert "8333893: Optimization for StringBuilder append boolean & null"

Changes: https://git.openjdk.org/jdk/pull/23420/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23420&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8349183
  Stats: 133 lines in 5 files changed: 18 ins; 79 del; 36 mod
  Patch: https://git.openjdk.org/jdk/pull/23420.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/23420/head:pull/23420

PR: https://git.openjdk.org/jdk/pull/23420


More information about the core-libs-dev mailing list