RFR: 8346567: Make Class.getModifiers() non-native
ExE Boss
duke at openjdk.org
Mon Feb 3 17:49:20 UTC 2025
On Mon, 9 Dec 2024 20:27:52 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 1504:
>>
>>> 1502: macro(_reflectionData_offset, k, "reflectionData", java_lang_ref_SoftReference_signature, false); \
>>> 1503: macro(_signers_offset, k, "signers", object_array_signature, false); \
>>> 1504: macro(_modifiers_offset, k, vmSymbols::modifiers_name(), int_signature, false)
>>
>> Do we need a trailing semicolon here?
>
> yes. it is needed.
This is **C++**, so yes.
Suggestion:
macro(_modifiers_offset, k, vmSymbols::modifiers_name(), int_signature, false);
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22652#discussion_r1876794006
More information about the core-libs-dev
mailing list