RFR: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated [v5]

Volkan Yazici vyazici at openjdk.org
Tue Feb 4 14:26:24 UTC 2025


On Tue, 4 Feb 2025 14:15:00 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Volkan Yazici has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Replace `assert`s with conditionally thrown exceptions
>
> test/jdk/java/net/httpclient/http2/FixedThreadPoolTest.java line 180:
> 
>> 178:                 });
>> 179:         response.join();
>> 180:         assert Files.mismatch(src, dest) < 0;
> 
> Missed call to `assertFileContentsEqual`?

Doh! :facepalm: Fixed in 5e9b30f431676c714cf81b85846f16c58c0dcdf6.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23401#discussion_r1941272158


More information about the core-libs-dev mailing list